Skip to content

chore: address commit comments for commit bb378ff (issue #6499) #6565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2025
Merged

chore: address commit comments for commit bb378ff (issue #6499) #6565

merged 1 commit into from
Apr 5, 2025

Conversation

@PrathamBhamare
Copy link
Contributor

@PrathamBhamare PrathamBhamare commented Apr 5, 2025 •
edited
Loading

Resolves #6499

Description

What is the purpose of this pull request?

This pull request:

  • Updates example output formatting in the README and example files for log10, log2, and logf to use integer (%d) format for input values and floating-point (%0.4f) for output values.
  • Ensures consistency with stdlib’s preferred output formatting and improves readability of documentation.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

All 6 comments from commit bb378ff have been addressed, including:

  • Updating format strings for logEachMap in:
    • log10 README and examples
    • log2 README and examples
    • logf README and examples

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Apr 5, 2025
stdlib-bot
stdlib-bot reviewed Apr 5, 2025
View reviewed changes
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Apr 5, 2025

Coverage Report

Package Statements Branches Functions Lines
math/base/special/log10 $\color{green}307/307$
$\color{green}+100.00\%$ 		$\color{green}16/16$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}307/307$
$\color{green}+100.00\%$
math/base/special/log2 $\color{green}290/290$
$\color{green}+100.00\%$ 		$\color{green}16/16$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}290/290$
$\color{green}+100.00\%$
math/base/special/logf $\color{green}172/172$
$\color{green}+100.00\%$ 		$\color{green}5/5$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}172/172$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Planeshifter
Planeshifter approved these changes Apr 5, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Apr 5, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Apr 5, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Apr 5, 2025

PR Commit Message

chore: address commit comments for commit bb378ff (issue #6499)

PR-URL: https://github.com/stdlib-js/stdlib/pull/6565
Closes: https://github.com/stdlib-js/stdlib/issues/6499

Co-authored-by: PrathamBhamare <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@PrathamBhamare
Copy link
Contributor Author

PrathamBhamare commented Apr 5, 2025

✅ Commit message looks good to me.

@Planeshifter Planeshifter merged commit 5c0b04d into stdlib-js:develop Apr 5, 2025
104 checks passed
@PrathamBhamare PrathamBhamare mentioned this pull request Apr 8, 2025
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stdlib-bot stdlib-bot stdlib-bot left review comments

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Address commit comments (commit bb378ff)

3 participants

@PrathamBhamare @stdlib-bot @Planeshifter